Adding filter-buttons in pod list view #21
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| "click #show_all_pods": "showAllPods", | ||
| "click #show_active_pods": "showActivePods", | ||
| "click #show_blocked_pods": "showBlockedPods", | ||
| "click #show_invalid_pods": "showInvalidPods", |
There was a problem hiding this comment.
comma-dangle: Unexpected trailing comma.
|
|
||
| initialize: function() { | ||
| this.pods = new app.collections.Pods(app.parsePreload("pods")); | ||
| this.rows = []; // contains the table row views | ||
| this.podfilter = 'active'; |
There was a problem hiding this comment.
quotes: Strings must use doublequote.
| }, | ||
|
|
||
| showAllPods: function() { | ||
| this.podfilter = ''; |
There was a problem hiding this comment.
quotes: Strings must use doublequote.
| }, | ||
|
|
||
| showActivePods: function() { | ||
| this.podfilter = 'active'; |
There was a problem hiding this comment.
quotes: Strings must use doublequote.
| }, | ||
|
|
||
| showBlockedPods: function() { | ||
| this.podfilter = 'blocked'; |
There was a problem hiding this comment.
quotes: Strings must use doublequote.
| }).render()); | ||
| this.$("tbody").empty(); | ||
|
|
||
| this.pods.each(function (pod) { |
There was a problem hiding this comment.
space-before-function-paren: Unexpected space before function parentheses.
| this.$("tbody").empty(); | ||
|
|
||
| this.pods.each(function (pod) { | ||
| if (self.podfilter === '' || |
There was a problem hiding this comment.
quotes: Strings must use doublequote.
|
|
||
| this.pods.each(function (pod) { | ||
| if (self.podfilter === '' || | ||
| self.podfilter === 'active' && pod.get("status") === "no_errors" || |
There was a problem hiding this comment.
quotes: Strings must use doublequote.
| this.pods.each(function (pod) { | ||
| if (self.podfilter === '' || | ||
| self.podfilter === 'active' && pod.get("status") === "no_errors" || | ||
| self.podfilter === 'blocked' && pod.get("blocked") === true || |
There was a problem hiding this comment.
quotes: Strings must use doublequote.
| if (self.podfilter === '' || | ||
| self.podfilter === 'active' && pod.get("status") === "no_errors" || | ||
| self.podfilter === 'blocked' && pod.get("blocked") === true || | ||
| self.podfilter === 'invalid' && pod.get("status") !== "no_errors") { |
There was a problem hiding this comment.
- quotes: Strings must use doublequote.
- padded-blocks: Block must not be padded by blank lines.
tclaus
force-pushed
the
feature/filter_pods_in_admnin_view
branch
from
b774019
to
417187c
Compare
Style fixes