-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data-test-id plugin integration #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @rwpswami!! I messed around with the failure and I'm not sure what is going on. I'll spend some time on it this weekend and see if I can figure out why it isn't registering the rule.
package.json
Outdated
@@ -54,6 +55,7 @@ | |||
}, | |||
"peerDependencies": { | |||
"eslint": "^7.0.0", | |||
"eslint-plugin-test-id": "^1.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"eslint-plugin-test-id": "^1.0.2", | |
"eslint-plugin-test-id": "^1.0.0", |
@rwpswami I didn't have any luck. I think it might be something related to relative paths? I tried a few other plugins to see if I'd hit the same issue and I didn't have any issues. |
I think you are right. This might be related to path. So I have released new version with relative path. Also I have added facility to integrate the plugin as extension. So we don't have to add rules separately. Thanks for your time. I really appreciate it. |
index.js
Outdated
parserOptions: { | ||
parser: 'babel-eslint', | ||
}, | ||
plugins: ['vue', 'vuejs-accessibility', 'test-id'], | ||
plugins: ['vue', 'vuejs-accessibility'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding extends support, @rwpswami 🎉 I think we still want to list the plugin in addition to the extends section. Would you mind adding it back?
plugins: ['vue', 'vuejs-accessibility'], | |
plugins: ['vue', 'vuejs-accessibility', 'test-id'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes sure. Added back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tclindner Please take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! Nice work, @rwpswami 🙌
I will get a new version out today! |
@tclindner I am not sure about this integration. Could you please help me in this?