Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-test-id plugin integration #188

Merged
merged 9 commits into from
Dec 15, 2020
Merged

Conversation

rwpswami
Copy link
Contributor

@tclindner I am not sure about this integration. Could you please help me in this?
image

Copy link
Owner

@tclindner tclindner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rwpswami!! I messed around with the failure and I'm not sure what is going on. I'll spend some time on it this weekend and see if I can figure out why it isn't registering the rule.

package.json Outdated
@@ -54,6 +55,7 @@
},
"peerDependencies": {
"eslint": "^7.0.0",
"eslint-plugin-test-id": "^1.0.2",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"eslint-plugin-test-id": "^1.0.2",
"eslint-plugin-test-id": "^1.0.0",

@tclindner
Copy link
Owner

@rwpswami I didn't have any luck. I think it might be something related to relative paths? I tried a few other plugins to see if I'd hit the same issue and I didn't have any issues.

@rwpswami
Copy link
Contributor Author

rwpswami commented Dec 14, 2020

@rwpswami I didn't have any luck. I think it might be something related to relative paths? I tried a few other plugins to see if I'd hit the same issue and I didn't have any issues.

I think you are right. This might be related to path. So I have released new version with relative path. Also I have added facility to integrate the plugin as extension. So we don't have to add rules separately.
All test cases have passed now 🎉

Thanks for your time. I really appreciate it.

index.js Outdated
parserOptions: {
parser: 'babel-eslint',
},
plugins: ['vue', 'vuejs-accessibility', 'test-id'],
plugins: ['vue', 'vuejs-accessibility'],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding extends support, @rwpswami 🎉 I think we still want to list the plugin in addition to the extends section. Would you mind adding it back?

Suggested change
plugins: ['vue', 'vuejs-accessibility'],
plugins: ['vue', 'vuejs-accessibility', 'test-id'],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sure. Added back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tclindner Please take a look

Copy link
Owner

@tclindner tclindner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Nice work, @rwpswami 🙌

@tclindner tclindner merged commit a04d974 into tclindner:master Dec 15, 2020
@tclindner
Copy link
Owner

I will get a new version out today!

@tclindner tclindner added this to the v7.0.0 milestone Dec 15, 2020
@tclindner tclindner added the enhancement 👑 New feature or request label Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 👑 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants