Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve rule loader support for array type rules #56

Closed
tclindner opened this issue Aug 24, 2017 · 1 comment · Fixed by chauncey-garrett/dotfiles#22
Closed

Improve rule loader support for array type rules #56

tclindner opened this issue Aug 24, 2017 · 1 comment · Fixed by chauncey-garrett/dotfiles#22
Assignees
@tclindner
Labels
enhancement 👑 New feature or request
Milestone
v2.9.0

Comments

@tclindner
Copy link
Owner

npm-package-json-lint has two types of rules. The first type allows users to set their severity level (i.e. off, warning, and error). The second type allows users to pass an array of values with the severity level. Currently, the rules loader is not coded in a way that scales for varying types of array based rules. The goal of this issue is to improve that process and prevent future issues like #53.

FYI @evilebottnawi
@tclindner tclindner added the enhancement 👑 New feature or request label Aug 24, 2017
@tclindner tclindner self-assigned this Aug 24, 2017
@tclindner tclindner added this to the v2.9.0 milestone Aug 30, 2017
tclindner added a commit that referenced this issue Aug 30, 2017
@tclindner
Closes #56 - Update config validation to static rules
ef992ba 
Update npm package json lint to call validate when rule is being
processed
@tclindner
Copy link
Owner Author

v2.9.0 has been released with the new rules loader logic. All existing rules should run the same as they did in v2.8.2. @evilebottnawi and @moshest let me know if you see any issues.

@dependencies dependencies bot mentioned this issue Aug 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tclindner tclindner

Labels
enhancement 👑 New feature or request
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging a pull request may close this issue.

Update npm-package-json-lint from 2.5.0 to 2.9.0 chauncey-garrett/dotfiles
1 participant
@tclindner