Eliminate some clang warnings. Only use "testbigdata" if sizeof(Tcl_S…

…ize) == sizeof(Tcl_WideInt)
tcltk · May 25, 2023 · 0657f97 · 0657f97
1 parent 231fd11
commit 0657f97
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/generic/tclTest.c b/generic/tclTest.c
@@ -5761,6 +5761,9 @@ TestbytestringObjCmd(
 #if !defined(TCL_NO_DEPRECATED)
 #   if defined(_MSC_VER) && !defined(NDEBUG)
 #	pragma warning(disable:4133)
+#   elif defined(__clang__)
+#	pragma clang diagnostic push
+#	pragma clang diagnostic ignored "-Wincompatible-pointer-types"
 #   endif
 	int n; /* On purpose, not Tcl_Size, in order to demonstrate what happens */
 #else
@@ -5779,6 +5782,10 @@ TestbytestringObjCmd(
     if (p == NULL) {
 	return TCL_ERROR;
     }
+#if !defined(TCL_NO_DEPRECATED) && defined(__clang__)
+#   pragma clang diagnostic pop
+#endif
+
     if (x.m != 1) {
 	Tcl_AppendResult(interp, "Tcl_GetBytesFromObj() overwrites variable", NULL);
 	return TCL_ERROR;

diff --git a/generic/tclTestObj.c b/generic/tclTestObj.c
@@ -119,8 +119,10 @@ TclObjTest_Init(
     Tcl_CreateObjCommand(interp, "testobj", TestobjCmd, NULL, NULL);
     Tcl_CreateObjCommand(interp, "teststringobj", TeststringobjCmd,
 	    NULL, NULL);
-    Tcl_CreateObjCommand(interp, "testbigdata", TestbigdataCmd,
-	    NULL, NULL);
+    if (sizeof(Tcl_Size) == sizeof(Tcl_WideInt)) {
+	Tcl_CreateObjCommand(interp, "testbigdata", TestbigdataCmd,
+		NULL, NULL);
+    }
     return TCL_OK;
 }