Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tcl for windows/arm64 target #10

Closed
wants to merge 1 commit into from

Conversation

niyas-sait
Copy link

No description provided.

andreas-kupries pushed a commit that referenced this pull request Feb 5, 2022
@niyas-sait
Copy link
Author

Many thanks, @nijtmans, and @andreas-kupries for pushing the patch to tcl official repository.

Could you help with similar changes for TK Package as well? tcltk/tk#12

@nijtmans
Copy link
Member

nijtmans commented Feb 8, 2022

Thank you for this contribution. As it is now, it should be sufficient to build a static version of tclsh, but a dynamic one will not work yet. The problem is that tcl86.dll depends on zlib1.dll, which is not provided for arm64. So, that's the next step on my TODO list. I wouldn't be surprised if more problems arise, feel free to report them.

Best way to get our attention is to file a ticket here, since github is only a mirror of the official Tcl repo

@niyas-sait
Copy link
Author

Thanks a lot, @nijtmans. Yes, I hit the same problem with dynamic builds. Zlib for windows-arm64 needs a minor tweak to the base address for the DLL to compile.

If you remove the explicit base_address from zlib's win32\Makefile.msc then it can be compiled and seems to work. It is not clear to me why zlib have the explicit default base address. I've asked the zlib maintainers if it is okay to remove them for arm64 builds.

niyas-sait pushed a commit to niyas-sait/cpython-source-deps that referenced this pull request Feb 9, 2022
@nijtmans nijtmans self-assigned this Feb 10, 2022
@nijtmans nijtmans added accepted It's sorted (since this is a mirror, we can't directly accept the PR) enhancement It would make the code better if… labels Feb 10, 2022
@nijtmans nijtmans closed this Feb 10, 2022
@niyas-sait
Copy link
Author

Thanks @nijtmans. I've raised https://core.tcl-lang.org/tcl/tktview/d109376adf418ce6d047fb0017d40848272a518f for cross-compilation support

sebres pushed a commit to sebres/tcl that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted It's sorted (since this is a mirror, we can't directly accept the PR) enhancement It would make the code better if…
Projects
None yet
2 participants