Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix File Encoding Issues when writing java files #10

Closed
tcmj opened this issue Jul 11, 2017 · 3 comments
Closed

Fix File Encoding Issues when writing java files #10

tcmj opened this issue Jul 11, 2017 · 3 comments
Labels
bug Error
Milestone

Comments

@tcmj
Copy link
Owner

tcmj commented Jul 11, 2017

  • clean utf-8 support and
  • ability to change the encoding
  • due to platform needs

-default to utf-8
-ability to change it with the standard maven property ?
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

@tcmj tcmj created this issue from a note in sprint_1_2_7_1 (Backlog) Jul 11, 2017
@tcmj tcmj removed this from Backlog in sprint_1_2_7_1 Jul 11, 2017
@tcmj tcmj added the bug Error label Jul 11, 2017
@tcmj tcmj removed this from Ready in sprint_1_2_7_15 Jul 18, 2017
@tcmj tcmj added this to open in sprint_1_2_9_15 Sep 5, 2017
@tcmj tcmj removed this from open in sprint_1_2_9_15 Dec 20, 2017
@tcmj tcmj added this to open in sprint_1_3_1 Mar 17, 2018
@tcmj tcmj added this to the 1.3.1 milestone Mar 17, 2018
@tcmj
Copy link
Owner Author

tcmj commented Apr 4, 2018

Priority: Minor
Todo: find concrete issues
Atm everything should be bound to UTF-8 which should be fine

@tcmj tcmj removed this from open in sprint_1_3_1 Apr 4, 2018
@tcmj tcmj added this to in progress in sprint_1_3_2 Oct 23, 2018
@tcmj
Copy link
Owner Author

tcmj commented Oct 23, 2018

added a new property to our maven mojo

 @Parameter(defaultValue = "${project.build.sourceEncoding}", required = true, readonly = true)
  private String encoding;

@tcmj
Copy link
Owner Author

tcmj commented Oct 23, 2018

Additionally we can see the encoding used in the info log message:
[INFO] * * SourceOutputDirectory: 'D:\gitwork\workspace-tcmj-iso\tcmj-pug-enums\examples-api\src\main\generated', OutputEncoding: UTF-8 * *

@tcmj tcmj moved this from in progress to finished in sprint_1_3_2 Oct 23, 2018
tcmj added a commit that referenced this issue Oct 23, 2018
@tcmj tcmj closed this as completed Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Error
Projects
No open projects
Development

No branches or pull requests

1 participant