Javascript slim expressions #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix unit test for CachedInteraction
… for symbols containing a map directly, not only on html-string representation of hashtable
…d(). Also ensure unknown keys and hash values are returned to wiki as string containing full expression
|
Works great! I've been trying to get the values back into the wiki as well (in case the symbols were set using wiki markup), but the only way I get it working is by creating a ParserHelper like ParserTestHelper that creates dummy test pages in memory in order to get the HTML representation of a hash. |
|
But I believe being able to use the variable's content as an expected value. And for that I believe the wiki must have the content.... |
|
|
tcnh
force-pushed
the
referenceMapValuesFromSlimSymbols
branch
from
3bee0d9
to
78e13ab
Compare
tcnh
pushed a commit
that referenced
this pull request
Mar 21, 2023
Merge pull request unclebob#1382 from jediwhale/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use javascript expressions on slim symbols between $``, which also allows map values to be retrieved