Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all non-passing tests in call_spec. #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mvastola
Copy link

The only non-passing tests remaining (though there are admittedly a lot, I think they're all related) are in wrapper_spec.rb.
Partially fixes Issue #36

The tests I fixed were failing because they relied on the exported files from pdftk being exactly identical to a file contained within the gem. This can't ever be guaranteed to be platform/version-independant since even an inconsistency in the order in which the PDFs array of properties enumerates itself (which could be caused by something as simple as a compiler optimization) would cause the test to fail. I parsed the data in these failing tests with a regex and converted them to a hash before comparing and the tests then matched.


Also, @tcocca, I am interested in working more on this project and fixing it up to get it live on RubyGems. I think I can figure out the other testing bugs. I only had a few hours to play with it right now and got pretty far so I thought I'd make this pull request.

Is there any way I could contact you so we can chat briefly at some point if you'd be interested?

The only non-passing tests remaining
(though there are admittedly a lot,
I think they're all related) are in
wrapper_spec.rb.
@tcocca
Copy link
Owner

tcocca commented Nov 24, 2014

@mvastola thanks so much for the help on this, however, are these lines necessary?

s.add_development_dependency 'travis'
s.add_development_dependency 'byebug'

I think they are causing issues with the travis build: https://travis-ci.org/tcocca/active_pdftk/builds/41839419

Thanks,
~ Tom

@mvastola
Copy link
Author

@tcocca Oops. No, you should disappear 'travis', at least.
Byebug might be useful for development -- it's the equivalent for the 'ruby-debugger' gem for Ruby 2.0+, but it's not strictly 'necessary' for development, but -- then again -- necessary is relative.

@mvastola
Copy link
Author

Do you want me to remove the travis line (and possibly byebug too) and resubmit?

@tcocca
Copy link
Owner

tcocca commented Nov 24, 2014

Please remove both and re-submit the pull, and I'll see what happens with
travis.

Thanks.

On Mon, Nov 24, 2014 at 1:21 PM, Michael Vastola notifications@github.com
wrote:

Do you want me to remove the travis line (and possibly byebug too) and
resubmit?


Reply to this email directly or view it on GitHub
#45 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants