Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop cursor blink when screens are pushed #196

Closed
tconbeer opened this issue Sep 1, 2023 · 2 comments · Fixed by #214
Closed

Stop cursor blink when screens are pushed #196

tconbeer opened this issue Sep 1, 2023 · 2 comments · Fixed by #214
Labels
bug Something isn't working

Comments

@tconbeer
Copy link
Owner

tconbeer commented Sep 1, 2023

e.g., when exporting or opening help menu, cursor in the textarea shouldn't blink.
@tconbeer tconbeer added the bug Something isn't working label Sep 1, 2023
@tconbeer tconbeer added this to the v1.0.0 milestone Sep 5, 2023
@tconbeer
Copy link
Owner Author

tconbeer commented Sep 8, 2023

Pausing the timer doesn't work the way we'd want it to; blur() doesn't either. Don't think this is worth the effort right now (would need to implement a callback for every screen to restart the timer).

@tconbeer tconbeer removed this from the v1.0.0 milestone Sep 8, 2023
@tconbeer
Copy link
Owner Author

tconbeer commented Sep 8, 2023 •
edited

actually maybe we can listen for a screen resume event?
https://textual.textualize.io/api/events/#textual.events.ScreenResume

tconbeer added a commit that referenced this issue Sep 11, 2023
@tconbeer
fix #196: stop cursor blink under modal
8b7c6bf
@tconbeer tconbeer mentioned this issue Sep 11, 2023
Merged
tconbeer added a commit that referenced this issue Sep 11, 2023
@tconbeer
fix #196: stop cursor blink under modal (#214)
6aea2bc 
* fix #196: stop cursor blink under modal

* fix: remove test screenshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #196: stop cursor blink under modal tconbeer/harlequin
1 participant
@tconbeer