Skip to content

Commit

Permalink
mostly cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
tcurdt committed Feb 29, 2012
1 parent d792251 commit 699ae64
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 9 deletions.
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# jmx2any

java -javaagent:/path/jmx2any.jar=/etc/jmx2any.yml yourmainclass

java -jar /path/jmx2any.jar -config /etc/jmx2any.yml

jmx2any -config /etc/jmx2any.yml -print -all


# License

Expand Down
1 change: 0 additions & 1 deletion src/examples/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ output:
path: /tmp/output
report:
- java
- cassandra

cassandra:
url: "service:jmx:rmi:///jndi/rmi://localhost:7199/jmxrmi"
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/org/vafer/jmx/Agent.java
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@
import java.util.concurrent.TimeUnit;

/*
* java -javaagent:/path/jmx2any.jar=/etc/jmx2any.config yourmainclass
* java -javaagent:/path/jmx2any.jar=/etc/jmx2any.yml yourmainclass
*/
public final class Agent {

private final String filename;
private final String filename;
private final ScheduledThreadPoolExecutor executor;

public Agent(String filename) {
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/org/vafer/jmx/JmxQuery.java
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ public final class JmxBean implements Iterable<JmxQuery.JmxAttribute> {
public JmxBean(ObjectInstance mbean) throws IntrospectionException, InstanceNotFoundException, IOException, ReflectionException {
final ObjectName mbeanName = mbean.getObjectName();
final MBeanInfo mbeanInfo = connection.getMBeanInfo(mbeanName);
final Collection<JmxAttribute> attributes = new ArrayList<JmxAttribute>();

final Collection<JmxAttribute> attributes = new ArrayList<JmxAttribute>();
for (final MBeanAttributeInfo attribute : mbeanInfo.getAttributes()) {
if (attribute.isReadable()) {
attributes.add(new JmxAttribute() {
Expand Down Expand Up @@ -60,7 +60,7 @@ public Iterator<JmxAttribute> iterator() {
return attributes.iterator();
}
}

public JmxQuery(final String url, final Set<String> expressions) throws IOException, MalformedObjectNameException, IntrospectionException, InstanceNotFoundException, ReflectionException {
this.connector = JMXConnectorFactory.connect(new JMXServiceURL(url));
this.connection = connector.getMBeanServerConnection();
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/vafer/jmx/output/OutputFilter.java
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
public final class OutputFilter implements JmxPipe {

private final static DefaultFormatter formatter = new DefaultFormatter();

private final JmxPipe output;
private final Set<String> metrics;

Expand Down
1 change: 0 additions & 1 deletion src/main/java/org/vafer/jmx/pipe/CompositePipe.java
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ public void output(String node, JmxQuery.JmxAttribute metric) throws IOException
}
}


public void close() throws IOException {
for(JmxPipe output : outputs) {
output.close();
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/vafer/jmx/pipe/ConverterPipe.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
public final class ConverterPipe implements JmxPipe {

private final static DefaultFormatter formatter = new DefaultFormatter();

private final Output output;
private final Enums enums;

Expand Down

0 comments on commit 699ae64

Please sign in to comment.