Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Base URL handling #77

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Improve Base URL handling #77

merged 3 commits into from
Jan 5, 2024

Conversation

tdabasinskas
Copy link
Owner

Fixes #72 .

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (2a7ba57) 74.62% compared to head (eccbda9) 74.28%.

Files Patch % Lines
backstage/provider.go 16.66% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   74.62%   74.28%   -0.34%     
==========================================
  Files          11       11              
  Lines        1584     1583       -1     
==========================================
- Hits         1182     1176       -6     
- Misses        319      323       +4     
- Partials       83       84       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Took 29 minutes
@tdabasinskas tdabasinskas self-assigned this Jan 5, 2024
@tdabasinskas tdabasinskas marked this pull request as ready for review January 5, 2024 09:21
Took 3 minutes
@tdabasinskas tdabasinskas merged commit e50719f into main Jan 5, 2024
7 of 9 checks passed
@tdabasinskas tdabasinskas deleted the fix_72 branch January 5, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

base_url validation doesn't allow valid TLDs
1 participant