Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building addresses with province #42

Merged
merged 2 commits into from
Apr 20, 2020
Merged

Fix building addresses with province #42

merged 2 commits into from
Apr 20, 2020

Conversation

mam08ixo
Copy link
Contributor

@mam08ixo mam08ixo commented Apr 20, 2020

Region ID is not properly determined when the Faker address has a province property (instead of the more common state).

For CA addresses, the QuoteValidator then throws a LocalizedException when using the OrderBuilder:

Please check the shipping address information. "regionId" is required. Enter and try again.

This change attempts to read province first and falls back to state if the former is not set.

Note: This builds upon #41 and has to be merged thereafter.

@schmengler
Copy link
Collaborator

Thank you!

@schmengler schmengler merged commit 8d3f484 into tddwizard:master Apr 20, 2020
@mam08ixo mam08ixo deleted the CI-241 branch April 21, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants