You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Errors thrown in GraphQL execute phase are not handled:
node_1 | Error: Added label "field_name" is not included in initial labelset: [ 'operation_name', 'operation_name', 'phase' ]
node_1 | at validateLabel (/opt/node_app/node_modules/prom-client/lib/validation.js:20:10)
node_1 | at Counter.inc (/opt/node_app/node_modules/prom-client/lib/counter.js:24:4)
node_1 | at /opt/node_app/node_modules/@promster/apollo/dist/promster-apollo.cjs.dev.js:164:28
node_1 | at Array.forEach (<anonymous>)
node_1 | at /opt/node_app/node_modules/@promster/apollo/dist/promster-apollo.cjs.dev.js:163:160
node_1 | at /opt/node_app/node_modules/apollo-server-core/dist/utils/dispatcher.js:57:17
node_1 | at /opt/node_app/node_modules/apollo-server-core/dist/utils/schemaInstrumentation.js:76:56
node_1 | at processTicksAndRejections (node:internal/process/task_queues:96:5)
To Reproduce
Steps to reproduce the behavior:
And directive which throws an error in execute phase won't be handled / counted.
Describe the bug
Errors thrown in GraphQL execute phase are not handled:
To Reproduce
Steps to reproduce the behavior:
And directive which throws an error in execute phase won't be handled / counted.
Expected behavior
Expect
graphql_errors_total
to incrementAdditional context
Attempted to write a test for the issue here, not sure if the solution is correct https://github.com/tdeekens/promster/compare/main...earnubs:errors-in-execution-phase?expand=1
The text was updated successfully, but these errors were encountered: