Attempt to illustrate execute phase bug #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e965f69 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
earnubs
force-pushed
the
errors-in-execution-phase
branch
from
3349735
to
bdfca60
Compare
tdeekens
reviewed
Feb 15, 2022
| const schema = require('@graphql-tools/schema'); | ||
|
|
||
| const { makeExecutableSchema } = schema; | ||
| const { getDirective, mapSchema, MapperKind } = utils; |
There was a problem hiding this comment.
Nit: you can destructure this in the return of the require.
| schema, | ||
| fieldConfig, | ||
| directiveName | ||
| )?.[0]; |
There was a problem hiding this comment.
For readability I would not derefernce here. We can just add another firstDirective variable maybe which we either assign or destructure to.
| type Book { | ||
| title: String | ||
| author: String | ||
| isbn: String @error |
| const parsedMetrics = parsePrometheusTextFormat(rawMetrics); | ||
| const graphQlErrorsTotal = parsedMetrics.find( | ||
| (metric) => metric.name === 'graphql_errors_total' | ||
| ).metrics; |
earnubs
force-pushed
the
errors-in-execution-phase
branch
from
bdfca60
to
a26a33a
Compare
ensure that GraphQL errors thrown in execute phase are counted and that the plugin does not itself throw when it encounters such an error
earnubs
force-pushed
the
errors-in-execution-phase
branch
from
a26a33a
to
f4d06c7
Compare
tdeekens
previously approved these changes
Feb 16, 2022
Codecov Report
@@ Coverage Diff @@
## main #868 +/- ##
==========================================
+ Coverage 86.75% 87.15% +0.39%
==========================================
Files 22 22
Lines 506 506
Branches 119 119
==========================================
+ Hits 439 441 +2
+ Misses 58 56 -2
Partials 9 9
|
tdeekens
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is to demonstrate a potential bug with capturing error metrics in execute phase, and possible fix.
Description
Errors are not recorded when thrown in execute phase.
Technical debt & future