Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed PR gets rid of memory leaks that are introduced via "closure leaks".
The main problem was within the
validateSchema
method of theValidator
class.Three closures were produced there:
shouldResolve
,resolve
, and an<anonymous>
one.These three were mutually dependent. However,
shouldResolve
depends on no outer params, so it was taken out of thevalidateSchema
and promoted to a standalone function.resolve
became thesuperResolve
method, and the<anonymous>
one became theschemaTraverser
method of theValidator
class.In the same manner, the code in
helpers.js
was cleared. Affected are:deepMerge
importErrors
method of theValidatorResult
classtoString
method of theValidatorResult
classencodePath
method of theValidatorResult
class