Avoid IEEE-754 issues for multipleOf and divisibleBy #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o avoid IEEE-754 float innacuracies. This was causing, e.g. 2.4 not to be a multipleOf 0.1. The code multiplies by the minimum factor of 10 so that the modulo calculation is performed on integers. All credit goes to @manahga for coming up with this solution.
|
Thanks for making the changes for me @spacebaboon. I was just about to write back to tell you that I am a little swamped with work right now as well. Much Appreciated... |
spacebaboon
pushed a commit
to spacebaboon/react-jsonschema-form
that referenced
this pull request
Aug 18, 2017
Bump jsonschema dependency version to include fix to this issue. Fixed by tdegrunt/jsonschema#228 No test changes here, the json schema validation tests are in jsonschema.
4 tasks
n1k0
pushed a commit
to rjsf-team/react-jsonschema-form
that referenced
this pull request
Aug 18, 2017
Bump jsonschema dependency version to include fix to this issue. Fixed by tdegrunt/jsonschema#228 No test changes here, the json schema validation tests are in jsonschema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor multipleOf and divisibleBy to perform integer calculations to avoid IEEE-754 float innacuracies.
Resolves #187
This was causing, e.g. 2.4 not to be a multipleOf 0.1.
The code multiplies by the minimum factor of 10 so that the modulo calculation is performed on integers.
The validator code refactored to avoid repetition between multipleOf and divisibleBy validations, which are the same but with different names and error messages.
All credit goes to @manahga for coming up with this solution 👍