preValidateProperty + documentation #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to be implemented by users of the module.
|
Merged and pushed new version. Thank you both @KyleCartmell and @hugowetterberg for your effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tdegrunt
This PR is a dupe of #68 with some added documentation as requested.
I cannot reproduce the build failure. I've successfully run the full test suite as documented in the readme.
So, I'm opening a new PR for the same change in hopes that the TravisCI failure was temporal and that the newly included documentation will allow a merge.
(This is all @hugowetterberg's work I'm just packaging it. Great work, sir!)