Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SVG size units configurable #292

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented Apr 16, 2024

Firstly, thank you for this amazing library. I'm just starting with it, but it looks very powerful.

When generating SVG images for web pages, it is useful to specify the image size in pixels. Currently the SVG image size is hardcoded to be in millimeters. This PR makes it possible to configure that image size unit.

@tdewolff
Copy link
Owner

Thank you Tom. The SVG parser has shown tremendous interest, it will definitely need a great refactor and improvement. This is a step in that direction, thanks!

@tdewolff tdewolff merged commit b731d22 into tdewolff:master Apr 16, 2024
@twpayne twpayne deleted the svg-size-units branch May 8, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants