JS: support ECMAVersion < 2015 for template literals, fixes #621

tdewolff · Oct 27, 2023 · 08752f6 · 08752f6
1 parent b6acff4
commit 08752f6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/js/js.go b/js/js.go
@@ -900,7 +900,7 @@ func (m *jsMinifier) minifyExpr(i js.IExpr, prec js.OpPrec) {
 				m.write(notOneBytes)
 			}
 		} else if expr.TokenType == js.StringToken {
-			m.write(minifyString(expr.Data, true))
+			m.write(minifyString(expr.Data, m.o.minVersion(2015)))
 		} else if expr.TokenType == js.RegExpToken {
 			// </script>/ => < /script>/
 			if 0 < len(m.prev) && m.prev[len(m.prev)-1] == '<' && bytes.HasPrefix(expr.Data, regExpScriptBytes) {

diff --git a/js/js_test.go b/js/js_test.go
@@ -891,7 +891,7 @@ func TestJSVarRenaming(t *testing.T) {
 }
 
 func TestJSVersion(t *testing.T) {
-	versions := []int{2022, 2020, 2019, 2018}
+	versions := []int{2022, 2020, 2019, 2018, 2014}
 
 	jsTests := []struct {
 		version int
@@ -901,6 +901,7 @@ func TestJSVersion(t *testing.T) {
 	}{
 		{2020, `a==null?b:a`, `a==null?b:a`, `a??b`},
 		{2019, `try{}catch(a){}`, `try{}catch(a){}`, `try{}catch{}`},
+		{2015, `"<div onclick=\"alert('test')\">"`, `"<div onclick=\"alert('test')\">"`, "`<div onclick=\"alert('test')\">`"},
 	}
 
 	m := minify.New()