CSS: distinguish between empty and whitespace in custom variables

tdewolff · Jun 12, 2020 · 0ff4e9c · 0ff4e9c
1 parent 6a0abc1
commit 0ff4e9c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/css/css.go b/css/css.go
@@ -245,7 +245,11 @@ func (c *cssMinifier) minifyGrammar() error {
 			if _, err := c.w.Write(colonBytes); err != nil {
 				return err
 			}
-			if _, err := c.w.Write(parse.TrimWhitespace(c.p.Values()[0].Data)); err != nil {
+			value := parse.TrimWhitespace(c.p.Values()[0].Data)
+			if len(c.p.Values()[0].Data) != 0 && len(value) == 0 {
+				value = spaceBytes
+			}
+			if _, err := c.w.Write(value); err != nil {
 				return err
 			}
 			semicolonQueued = true

diff --git a/css/css_test.go b/css/css_test.go
@@ -304,7 +304,8 @@ func TestCSSInline(t *testing.T) {
 		{"--custom-variable:0px;", "--custom-variable:0px"},
 		{"--foo: 0px ;", "--foo:0px"},
 		{"--foo: if(x > 5) this.width = 10", "--foo:if(x > 5) this.width = 10"},
-		{"--foo: ;", "--foo:"},                // empty value
+		{"--foo: ;", "--foo: "},               // whitespace value
+		{"--foo:;", "--foo:"},                 // empty value
 		{"--foo: initial ;", "--foo:initial"}, // invalid value, serializes to empty
 		{"color=blue;", "color=blue"},
 		{"x: white , white", "x:white,white"},