More advice from deepsource.io

cmd/minify/fs.go

@@ -59,17 +59,6 @@ func DirFS(dir string) FS {
 	return dirFS(dir)
 }
 
-func containsAny(s, chars string) bool {
-	for i := 0; i < len(s); i++ {
-		for j := 0; j < len(chars); j++ {
-			if s[i] == chars[j] {
-				return true
-			}
-		}
-	}
-	return false
-}
-
 type dirFS string
 
 func (dir dirFS) Open(name string) (*os.File, error) {

cmd/minify/io_test.go

@@ -32,10 +32,10 @@ func TestConcat(t *testing.T) {
 }
 
 func TestConcatErr(t *testing.T) {
-	r, err := newConcatFileReader([]string{"err"}, testOpener)
+	_, err := newConcatFileReader([]string{"err"}, testOpener)
 	test.T(t, err, test.ErrPlain)
 
-	r, err = newConcatFileReader([]string{"test", "err"}, testOpener)
+	r, err := newConcatFileReader([]string{"test", "err"}, testOpener)
 	test.T(t, err, nil)
 
 	buf := make([]byte, 10)

html/html.go

@@ -324,9 +324,9 @@ func (o *Minifier) Minify(m *minify.M, w io.Writer, r io.Reader, _ map[string]st
 						if name := attrs[3]; name != nil {
 							name.AttrVal = parse.TrimWhitespace(name.AttrVal)
 							if parse.EqualFold(name.AttrVal, []byte("keywords")) {
-								content.AttrVal = bytes.Replace(content.AttrVal, []byte(", "), []byte(","), -1)
+								content.AttrVal = bytes.ReplaceAll(content.AttrVal, []byte(", "), []byte(","))
 							} else if parse.EqualFold(name.AttrVal, []byte("viewport")) {
-								content.AttrVal = bytes.Replace(content.AttrVal, []byte(" "), []byte(""), -1)
+								content.AttrVal = bytes.ReplaceAll(content.AttrVal, []byte(" "), []byte(""))
 								for i := 0; i < len(content.AttrVal); i++ {
 									if content.AttrVal[i] == '=' && i+2 < len(content.AttrVal) {
 										i++

js/js.go

@@ -260,8 +260,6 @@ func (m *jsMinifier) minifyStmt(i js.IStmt) {
 		m.writeSpaceBeforeIdent()
 		m.minifyExpr(stmt.Value, js.OpAssign)
 		m.write(closeParenBytes)
-		if len(stmt.Body.List) == 1 {
-		}
 		m.minifyBlockAsStmt(&stmt.Body, iterationBlock)
 	case *js.SwitchStmt:
 		m.write(switchOpenBytes)

js/util.go

@@ -25,7 +25,6 @@ var (
 	openBracketBytes           = []byte("[")
 	closeBracketBytes          = []byte("]")
 	openParenBracketBytes      = []byte("({")
-	closeBracketParenBytes     = []byte("})")
 	closeParenOpenBracketBytes = []byte("){")
 	notBytes                   = []byte("!")
 	questionBytes              = []byte("?")
@@ -34,7 +33,6 @@ var (
 	andBytes                   = []byte("&&")
 	orBytes                    = []byte("||")
 	optChainBytes              = []byte("?.")
-	nullishBytes               = []byte("??")
 	arrowBytes                 = []byte("=>")
 	zeroBytes                  = []byte("0")
 	oneBytes                   = []byte("1")
@@ -72,8 +70,6 @@ var (
 	openNewBytes               = []byte("(new")
 	newTargetBytes             = []byte("new.target")
 	importMetaBytes            = []byte("import.meta")
-	varBytes                   = []byte("var")
-	varSpaceBytes              = []byte("var ")
 	nanBytes                   = []byte("NaN")
 	undefinedBytes             = []byte("undefined")
 	infinityBytes              = []byte("Infinity")
@@ -85,7 +81,6 @@ var (
 	groupedNotZeroBytes        = []byte("(!0)")
 	notOneBytes                = []byte("!1")
 	groupedNotOneBytes         = []byte("(!1)")
-	useStrictBytes             = []byte(`"use strict"`)
 	debuggerBytes              = []byte("debugger")
 )
 

minify_test.go

@@ -317,15 +317,16 @@ func TestHelperProcess(*testing.T) {
 			os.Exit(1)
 			return
 		}
-		defer w.Close()
 
 		b, err := ioutil.ReadFile(in)
 		if err != nil {
 			w.WriteString(err.Error())
+			w.Close()
 			os.Exit(1)
 			return
 		}
 		_, _ = w.Write(b)
+		w.Close()
 	case "dummy/err":
 		fmt.Fprint(os.Stderr, "error")
 		os.Exit(1)
@@ -347,7 +348,7 @@ func ExampleM_Minify_custom() {
 			if err != nil && err != io.EOF {
 				return err
 			}
-			if _, errws := io.WriteString(w, strings.Replace(line, " ", "", -1)); errws != nil {
+			if _, errws := io.WriteString(w, strings.ReplaceAll(line, " ", "")); errws != nil {
 				return errws
 			}
 			if err == io.EOF {

svg/svg.go

@@ -18,10 +18,7 @@ var (
 	isBytes       = []byte("=")
 	spaceBytes    = []byte(" ")
 	cdataEndBytes = []byte("]]>")
-	pathBytes     = []byte("<path")
-	dBytes        = []byte("d")
 	zeroBytes     = []byte("0")
-	n100pBytes    = []byte("100%")
 	cssMimeBytes  = []byte("text/css")
 	noneBytes     = []byte("none")
 	urlBytes      = []byte("url(")