Skip to content

Commit

Permalink
Fix NodeJS workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
tdewolff committed Sep 24, 2022
1 parent 1ff5167 commit d6f28af
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-2019]
#os: [ubuntu-latest, macos-latest, windows-2019]
os: [ubuntu-latest, macos-latest]
node: [14, 18]

runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -43,7 +44,7 @@ jobs:
npm test
build:
#if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -80,7 +81,7 @@ jobs:
path: bindings/js/prebuilds/*/*.node

deploy:
#if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
needs: [build]
runs-on: ubuntu-latest
steps:
Expand Down

0 comments on commit d6f28af

Please sign in to comment.