Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"type" attribute lowercasing not always desirable #270

Closed
kabukky opened this issue Nov 12, 2019 · 1 comment
Closed

"type" attribute lowercasing not always desirable #270

kabukky opened this issue Nov 12, 2019 · 1 comment

Comments

@kabukky
Copy link

kabukky commented Nov 12, 2019

According to https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes the "type" attribute is only specified for <button>, <input>, <command>, <embed>, <object>, <script>, <source>, <style>, <menu>.

However, AMP are using the "type" attribute on <amp-analytics> as well.

We've run into issues where the "type" attribute value is case sensitive, specifically with the Adobe Analytics implementation: When using Minify, "adobeanalytics_nativeConfig" gets lowercased to "adobeanalytics_nativeconfig" which breaks the implementation.

Could you enable "type" attribute lowercasing only for specific HTML tags, e. g. the ones in the HTML spec?

@tdewolff
Copy link
Owner

See d843c10, 3f30656, 261d800 for the fix. This will fix a wider range of potential bugs by ensuring that only HTML5 element attributes are minified specially, following the Living HTML specification: https://html.spec.whatwg.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants