Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple og:image meta tags #178

Merged
merged 1 commit into from May 19, 2017
Merged

fix multiple og:image meta tags #178

merged 1 commit into from May 19, 2017

Conversation

machu
Copy link
Member

@machu machu commented May 14, 2017

tdiary/tdiary-core#629 の修正に合わせて、tdiary-core側とコードが重複しないように整理しました。

  • 基本的なogp要素はcore側が出力した値を使う
  • ogpプラグインは以下の値を出力する
    • fb:app_idなどのベンダー拡張要素
    • dayモードでは日記本文から生成したogp:description, ogp:image
    • 重複する要素はogpプラグイン側で削除する

@tdtds tdtds merged commit bbeca39 into master May 19, 2017
@tdtds tdtds deleted the fix-multiple-og-image branch May 19, 2017 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants