Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SAFE=1 and Safe::safe #666

Merged
merged 6 commits into from Jan 29, 2018
Merged

Remove SAFE=1 and Safe::safe #666

merged 6 commits into from Jan 29, 2018

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Jan 29, 2018

Ruby 2.6 will be modified scope of SAFE level.

ruby/ruby@c39bdb7

It breaks Thread local usage of SAFE level. So, We gave up to support SAFE mechanism in core module of tDiary.

Fixes #661

@machu machu temporarily deployed to tdiary-dev-pr-666 January 29, 2018 02:43 Inactive
  Ruby 2.6 will be modified scope of SAFE level.

  ruby/ruby@c39bdb7

  It break Thread local usage of SAFE level. So, We gave up to
  support SAFE mechanism in core module of tDiary.
@hsbt hsbt temporarily deployed to tdiary-dev-pr-666 January 29, 2018 05:47 Inactive
@hsbt hsbt temporarily deployed to tdiary-dev-pr-666 January 29, 2018 07:15 Inactive
@hsbt hsbt requested a review from tdtds January 29, 2018 07:31
@hsbt hsbt self-assigned this Jan 29, 2018
@tdtds tdtds added this to リリース候補 in 5.0.8リリース via automation Jan 29, 2018
@tdtds tdtds moved this from リリース候補 to 作業中 in 5.0.8リリース Jan 29, 2018
@tdtds
Copy link
Member

tdtds commented Jan 29, 2018

良いと思うのでマージしちゃいます。

@tdtds
Copy link
Member

tdtds commented Jan 29, 2018

……と思ったけど、まだいじる?

@hsbt
Copy link
Member Author

hsbt commented Jan 29, 2018

終わってます!

@hsbt hsbt merged commit eee51c5 into master Jan 29, 2018
5.0.8リリース automation moved this from 作業中 to 完了 Jan 29, 2018
@hsbt hsbt deleted the remove-safe-level1 branch January 29, 2018 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants