Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mvn assembly to remove the version number from the server-boot.jar in the installation folder #14

Merged
merged 1 commit into from
May 2, 2024
Merged

Use mvn assembly to remove the version number from the server-boot.jar in the installation folder #14

merged 1 commit into from
May 2, 2024

Conversation

abollini
Copy link

@abollini abollini commented May 2, 2024

No description provided.

@abollini abollini mentioned this pull request May 2, 2024
Merged
@tdonohue
Copy link
Owner

tdonohue commented May 2, 2024

Thanks for the suggestion, @abollini ! This makes sense to me to have Maven rename the JAR to simply be server-boot.jar. I've tested this change locally via Docker and it works well.

@tdonohue tdonohue merged commit 58d5005 into tdonohue:fixes_for_runnable_jar May 2, 2024
@abollini abollini deleted the fixes_for_runnable_jar_assembly branch May 3, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@abollini @tdonohue