Refactor item counter fixes after review #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em model (discoverable, archived, withdrawn)
…em model (discoverable, archived, withdrawn)
…ctor_item_counter
…ctor_item_counter
…ctor_item_counter
tdonohue
approved these changes
May 24, 2024
There was a problem hiding this comment.
👍 Thanks @damian-joz ! These improvements look good and make sense to me, and they pass all existing tests. I'll merge these into my PR's branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Add references/links to any related issues or PRs. These may include:
Description
Level up counting items methods - both now use the same flags from Item model (discoverable, archived, withdrawn)
Instructions for Reviewers
The same as in DSpace#9583
List of changes in this PR: