-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Voice contacts show phone number instead of name #52
Comments
How could I help with this bug? Are there network logs or something I could grab for you? Also it seems like somewhere in the fixes for #4, the contact's phone numbers are no longer displayed and instead it just shows "Unknown" for every Google Voice contact. I don't know which bug to post that on here though. |
A log of the requests used to retrieve the contacts would be useful. |
Am I doing something wrong in that I just get them all as "Unknown"? |
@uriel1998 No. That's an issue currently |
@AshenDrops Herm. I'm just pulling from github. Rats. I may have to completely pull it out and reinstall it just to make sure I didn't jack something up. |
@uriel1998 Ah, sorry. What I meant is that it's currently an unfixed issue where all Google Voice chats show up as "Unknown". It's present in the latest version |
Oh, okay. I was just looking at the screengrab earlier where it presented On Mon, Nov 23, 2015 at 6:58 PM, Ashen notifications@github.com wrote:
Steven Saus GPG key ID: 0xDD2F731F Your EULA doesn't apply: http://bit.ly/noeula |
Yeah. It was an error introduced at some point or another |
Anyone know what version of hangups made the phone numbers disappear? It might be easy to bring them back, but I'm not sure how it was working in the first place. |
I think it was one of the commits around #4 but I may be wrong. My guess is that the gvoice contacts have a different structure than the normal ones so they're be deserialized incorrectly causing an exception that results in the "Unknown" though that's a completely baseless assumption and I can't seem to find the |
Would it be feasible/desirable to integrate with something like ppl, a On Sat, Nov 28, 2015 at 2:14 PM, Addison Amiri notifications@github.com
Steven Saus GPG key ID: 0xDD2F731F Your EULA doesn't apply: http://bit.ly/noeula |
Interesting idea, I haven't heard of ppl before. We'd have to fix this issue first thought, otherwise there would be nothing to correlate the contacts between hangups and ppl. |
Is there a way to allow users to edit the name of the conversation client side so that we can at least work around the 'Unknown' issue? This would also be a nice feature when users would like to add nicknames. |
There's no support for custom client side names, but it would be possible to implement. |
@bolens1112 One thing you can do is add a "name" to the conversation. Go into the conversation and press Ctrl+N, then change the conversation name using the menu provided. It won't change the actual person's name within the conversation, but it will change the tab name and the name in the list. Note that if you do this on normal hangouts conversations the name will be set for the chat as a whole and seen by everyone. |
@baskervald That sounds good, but does that mean that if I name a conversation 'wife' it will show as 'wife' for the person on the other end as well? |
Yes, it changes the conversation name on the server-side. |
For anyone having issues with Google Voice contacts, #200 is a possible fix. |
@bolens1112 It will show as "wife" for Google Hangouts contacts, but not for Google Voice contacts |
I'd like to update this with the fact that Google does indeed use a private People v2 API to lookup metadata matching the phone number to a name -- typically only if they exist in your contacts, but it seems like it also has names for numbers that don't as well. Here's a sample response bit:
In addition, the |
Has any improvement been made on this issue? #200 has not made any changes for me. Some conversations through voice have names, and some don't. This is what it looks like for me:
|
@avaidyam, do you have any more details on the API endpoint used? |
Many people (including myself) link their Google Voice numbers to their Google Hangouts, so they can text from Hangouts. The way the official clients work is, they check the numbers in your Contacts and let you know whose number it is in the list, so the hangouts API doesn't deliver that data.
For reference, that's how the list looks for me now. As you can see, the numbers can have multiple different formats depending on how they're entered, so, depending on how Google Contacts handles it, some conversion may be necessary.
I would recommend implementing it as a check on startup, and perhaps adding a keybind to refresh them, if you had added someone to your contacts while the app was open (maybe allow you to add them from within the app as well?)
The text was updated successfully, but these errors were encountered: