tdsl_command_ctx: do not blindly set the rows_affected value #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code should only respect the rows_affected value if the status value indicates that the DONE token contains a valid rows_affected value, which was not the case with the current DONE callback. The code now properly utilizes the count_valid() function. Added three new integration tests to check execute_rpc function reports the correct number of affected rows. workspace.code-workspace: Updated clangd path. Fixes #43 Signed-off-by: Mustafa Kemal GILOR <mustafagilor@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code should only respect the rows_affected value if the status value indicates that the DONE token contains a valid rows_affected value, which was not the case with the current DONE callback. The code now properly utilizes the count_valid() function.
Added three new integration tests to check execute_rpc function reports the correct number of affected rows.
workspace.code-workspace: Updated clangd path.
Fixes #43