Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows CI #34

Closed
slonopotamus opened this issue Dec 22, 2019 · 1 comment · Fixed by #35
Closed

Add Windows CI #34

slonopotamus opened this issue Dec 22, 2019 · 1 comment · Fixed by #35

Comments

@slonopotamus
Copy link
Collaborator

In #32, I discovered that kindlegen doesn't pass tests on Windows because of changes that happened more than a year ago. Instead of manual discovery, it would be much better if kindlegen ran its tests on Windows the same way it runs on Linux. Note however that currently language: ruby + os: windows is not supported on Travis, even tough their Windows nodes do have Ruby installed.

@slonopotamus slonopotamus changed the title Add Wndows CI Add Windows CI Dec 22, 2019
@tdtds
Copy link
Owner

tdtds commented Dec 24, 2019

I agree, but I will be trying to change CI service Travis to Github Actions. Please wait several time.

slonopotamus added a commit to slonopotamus/kindlegen that referenced this issue Jan 9, 2020
MacOS is not added due to absense of 64-bit kindlegen binary.
GitHub Actions uses Catalina which cannot run 32-bit binaries.

Resolves tdtds#34

eregon/use-ruby-action is used in workflow instead of actions/setup-ruby
because the latter doesn't yet support Ruby 2.7. See actions/setup-ruby#45
slonopotamus added a commit to slonopotamus/kindlegen that referenced this issue Jan 9, 2020
MacOS is not added due to absense of 64-bit kindlegen binary.
GitHub Actions uses Catalina which cannot run 32-bit binaries.

Resolves tdtds#34

eregon/use-ruby-action is used in workflow instead of actions/setup-ruby
because the latter doesn't yet support Ruby 2.7. See actions/setup-ruby#45
@tdtds tdtds closed this as completed in #35 Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants