Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the price #5

Open
omar16100 opened this issue Jul 5, 2018 · 4 comments
Open

Adding the price #5

omar16100 opened this issue Jul 5, 2018 · 4 comments

Comments

@omar16100
Copy link

Hi @tducret, it would be nice to have the price as well

@Bolzano-Weierstrass
Copy link

Hi @omar16100 , I'll have a look and I'll try to add a feature that shows the price

@bitofbreeze
Copy link
Contributor

any ideas about this? I tried with various user agents and css selectors and it worked with some combos but not consistently for all searches. I was thinking maybe just visit each product page in the results and scrape the price from there if it is easier or scrape an external site like camelcamelcamel (unfortunately they won't ever release an API).

@tducret
Copy link
Owner

tducret commented Jan 14, 2019

@CSFlorin Getting prices properly is hard. There a many kind of prices and it is difficult to pick one (for a book : hardcover, kindle, used...)
Visiting each product page seems a fair option, but it will take much longer to scrape.
It's worth trying anyway. There are many interesting things inside (other pictures, description, reviews...).

@bitofbreeze
Copy link
Contributor

I think I addressed this! #19

@jpeacock29 jpeacock29 mentioned this issue Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants