-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adding the price - issue#5 #7
Conversation
Pull Request Test Coverage Report for Build 59
💛 - Coveralls |
Very good job Thomas @Bolzano-Weierstrass. Unfortunately, I get different kind of prices :( For example : Also, when I test it with a amazon.fr search url, I only get N/A for prices. "Apprendre à programmer avec Python 3",4.2,36,N/A,https://www.amazon.fr/Apprendre-%C3%A0-programmer-avec-Python/dp/2212134347 I knew this was going to be difficult with all these kind of prices... |
hi @tducret , Thanks for the feedback, I noticed it... but since I did not know what was the goal of people using this soft (to buy, to rent, kindle,..) I thought one price would give an indication. Giving it a second thought, giving a price range (min - max) of all avaiable prices might be more interesting. What do you think ? Regarding the "using the search url directly problem". I've just noticed that Amazon uses EUR instead of € while it uses $ and not USD. I thought it used only single-char currency so it can be fixed. Thanks |
"Min price", "Max price" seems a pretty good idea yes. |
The issue is that Amazon translates everything even the html/css tags therefore is it very difficult to know what we scrap: one time it is 'paperback' and the next time it is 'broché'... |
What if we got all prices in a dict with the category indicated (without translation at first)? {
"paperback":"21.16$",
"kindle edition":"9.99$"
} or {
"broché":"20.50€",
"format kindle":"9.99€"
} It would allow to get the min/max, and even translate the different categories in the future. |
I am not convinced by what I've done. I manage to run it locally and I can retrieve only one price and its label given the product html. It is not sufficient to be interesting... |
Why do you say so @Bolzano-Weierstrass ?
|
Oh, nice :)
And I tested multiple commands I never got more than 2 not N/A prices(while it is not yout case) so I was not convinced. Moreover it complexifies the code quite a lot. Your call :) |
Weird... That may be Amazon anti-scraping protections :S |
answering #5 ticket.
This commit adds the price to retrieved features alongside the book title, average rating, number of ratings and URL.
Shouldn't create any additional bugs, if it does don't hesitate to contact me.