Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-AMENDMENT_COORDINATES_TRANSPOSED #54

Open
iDigBioBot opened this issue Jan 5, 2018 · 6 comments
Open

TG2-AMENDMENT_COORDINATES_TRANSPOSED #54

iDigBioBot opened this issue Jan 5, 2018 · 6 comments
Labels
Amendment Consistency CORE TG2 CORE tests SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2

Comments

@iDigBioBot
Copy link
Collaborator

iDigBioBot commented Jan 5, 2018

TestField Value
GUID f2b4a50a-6b2f-4930-b9df-da87b6a21082
Label AMENDMENT_COORDINATES_TRANSPOSED
Description Propose amendment of the signs of dwc:decimalLatitude and/or dwc:decimalLongitude to align the location with the dwc:countryCode.
TestType Amendment
Darwin Core Class Location
Information Elements ActedUpon dwc:decimalLatitude
dwc:decimalLongitude
Information Elements Consulted dwc:countryCode
Expected Response INTERNAL_PREREQUISITES_NOT_MET if any of dwc:decimalLatitude or dwc:decimalLongitude or dwc:countryCode are EMPTY; AMENDED dwc:decimalLatitude and dwc:decimalLongitude if the coordinates were transposed or one or more of the signs of the coordinates were reversed to align the location with dwc:countryCode; otherwise NOT_AMENDED
Data Quality Dimension Consistency
Term-Actions COORDINATES_TRANSPOSED
Parameter(s)
Source Authority
Specification Last Updated 2023-09-17
Examples [dwc:decimalLatitude="25.46", dwc:decimalLongitude="135.87", dwc:countryCode="AU": Response.status=AMENDED, Response.result=dwc:decimalLatitude="-25.46", Response.comment="Input fields contain interpretable values"]
[dwc:decimalLatitude="25.46", dwc:decimalLongitude="135.87", dwc:countryCode="": Response.status=NOT_AMENDED, Response.result="", Response.comment="dwc:countryCode is EMPTY"]
Source iDigBio, GBIF, BISON, FP, Kurator, ALA
References
Example Implementations (Mechanisms) Kurator
Link to Specification Source Code https://github.com/FilteredPush/geo_ref_qc/blob/master/src/main/java/org/filteredpush/qc/georeference/DwCGeoRefDQ.java#L324
Notes The dwc:geodeticDatum is not necessary for this test. The maximum positional shift between any geographic coordinate reference system and WGS84 is less than 6 km, so any hemisphere test that relies on a country code for consistency would not be affected by the potential shift. The prior VALIDATION for this test is VALIDATION_COORDINATE_COUNTRYCODE_CONSISTENT (adb27d29-9f0d-4d52-b760-a77ba57a69c9).
@iDigBioBot
Copy link
Collaborator Author

Comment by Paula Zermoglio (@pzermoglio) migrated from spreadsheet:
Should this be two separate tests?

@iDigBioBot
Copy link
Collaborator Author

Comment by Paul Morris (@chicoreus) migrated from spreadsheet:
Corresponding validation is COUNTRY_COORDINATE_MISMATCH (VALIDATION_COORDINATE_COUNTRY_INCONSISTENT)

@ArthurChapman ArthurChapman added the Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT label Jan 16, 2018
@tucotuco
Copy link
Member

tucotuco commented Apr 8, 2020

This one still has problems. I would replace the current Expected Response

"INTERNAL_PREREQUISITES_NOT_MET if dwc:decimalLatitude and dwc:decimalLongitude are EMPTY or the values of dwc:decimalLatitude and dwc:decimalLongitude passed to the dwc:countryCode specified source authority service were not in the same spatial reference system as that of the service; AMENDED if the supplied geographic coordinates were transposed or one or more of the signs were reversed (negated) to place the record in the region defined by the supplied dwc:countryCode; otherwise NOT_CHANGED"

with

"INTERNAL_PREREQUISITES_NOT_MET if any of dwc:decimalLatitude or dwc:decimalLongitude or dwc:countryCode is EMPTY; AMENDED if the supplied geographic coordinates were transposed or one or more of the signs were reversed (negated) to place the record in the region defined by the supplied dwc:countryCode; otherwise NOT_CHANGED"

For the Notes, I would add

"The dwc:geodeticDatum is not necessary for this test. The maximum positional shift between any geographic coordinate reference system and WGS84 is less than 6 km, so any hemisphere test that relies on a country code for consistency would not be affected by the potential shift."

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 8, 2020

We have a quorum, so edited accordingly, with one change "is" to "are".

@ArthurChapman
Copy link
Collaborator

Updated Note #50 to VALIDATION_COORDINATE_COUNTRYCODE_CONSISTENT (adb27d29-9f0d-4d52-b760-a77ba57a69c9)

@Tasilee
Copy link
Collaborator

Tasilee commented Sep 16, 2023

Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted". Also changed "Field" to "TestField" and "Output Type" to "TestType".

@chicoreus chicoreus added the CORE TG2 CORE tests label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Amendment Consistency CORE TG2 CORE tests SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2
Development

No branches or pull requests

5 participants