Merge pull request #59 from zumo-sk/develop

Changing date format tests to use all cultures without hard-coding
tdwright · Nov 8, 2018 · 3cdc377 · 3cdc377
2 parents 79c956c + ae7cfa2
commit 3cdc377
Showing 1 changed file with 36 additions and 10 deletions.
diff --git a/ConTabs.Tests/FormatTests.cs b/ConTabs.Tests/FormatTests.cs
@@ -9,22 +9,48 @@ namespace ConTabs.Tests
 {
     class FormatTests
     {
-        [TestCase("da"   , "yyyy/MM/dd", "2018-01-31")]
-        [TestCase("en-GB", "dd/MM/yy"  , "31/01/18"  )]
-        [TestCase("en-US", "MM/dd/yy"  , "01/31/18"  )]
-        //[TestCase("sk"   , "d/M/yyyy"  , "31.1.2018" )]
-        public void DateTimeFieldCanBeFormatted(string culture, string format, string expected)
+        [TestCase("da-DK")]
+        [TestCase("en-GB")]
+        [TestCase("en-US")]
+        [TestCase("sk-SK")]
+        [TestCase("zh-CN")]
+        public void DateTimeFieldCanBeFormattedRegardlessOfCulture(string cultureName)
         {
             // Arrange
-            Thread.CurrentThread.CurrentCulture = CultureInfo.CreateSpecificCulture(culture);
+            var refDate = new DateTime(2018, 01, 31);
+            var culture = CultureInfo.CreateSpecificCulture(cultureName);
+            Thread.CurrentThread.CurrentCulture = culture;
+
+            // Act
             var tableObj = Table<TestDataType>.Create();
+            tableObj.Columns[3].FormatString = "d-M-yyyy";
+            var val = tableObj.Columns[3].StringValForCol(refDate);
+
+            // Assert
+            val.ShouldBe("31-1-2018");
+        }
+
+        [TestCase("da-DK")]
+        [TestCase("en-GB")]
+        [TestCase("en-US")]
+        [TestCase("sk-SK")]
+        [TestCase("zh-CN")]
+        public void DateTimeFieldCanBeFormattedUsingCulture(string cultureName)
+        {
+            // Arrange
+            var refDate = new DateTime(2018, 01, 31);
+            var formatString = "dddd";
+            var culture = CultureInfo.CreateSpecificCulture(cultureName);
+            Thread.CurrentThread.CurrentCulture = culture;
+            var dateString = refDate.ToString(formatString, culture);
 
             // Act
-            tableObj.Columns[3].FormatString = format;
-            var val = tableObj.Columns[3].StringValForCol(new DateTime(2018, 01, 31));
-
+            var tableObj = Table<TestDataType>.Create();
+            tableObj.Columns[3].FormatString = formatString;
+            var val = tableObj.Columns[3].StringValForCol(refDate);
+
             // Assert
-            val.ShouldBe(expected);
+            val.ShouldBe(dateString);
         }
 
         [TestCase("en-GB", "£1.91")]