Merge branch 'master' into develop

ConTabs.Tests/Table-Basic.cs

@@ -1,6 +1,7 @@
 using NUnit.Framework;
 using Shouldly;
 using System.Collections.Generic;
+using ConTabs.Exceptions;
 using ConTabs.TestData;
 
 namespace ConTabs.Tests
@@ -43,7 +44,17 @@ public void TableObjectHasExpectedNumberOfColumns()
             // Assert
             table.Columns.Count.ShouldBe(4);
         }
-
+
+        [Test]
+        public void Table_GivenClassWithoutPublicProperties_ThrowsPublicPropertiesNotFoundException()
+        {
+            // Arrange
+            var listOfTestClasses = DataProvider.ListOfInvalidTestData();
+
+            // Assert
+            Assert.Throws<PublicPropertiesNotFoundException>(() =>
+                Table<InvalidTestDataType>.Create(listOfTestClasses));
+        }
     }
 
 

ConTabs/ConTabs.csproj

@@ -1,5 +1,4 @@
 <Project Sdk="Microsoft.NET.Sdk">
-
   <PropertyGroup>
     <TargetFrameworks>netstandard1.3;netstandard2.0;net45</TargetFrameworks>
     <PackageId>ConTabs.tdwright</PackageId>
@@ -16,10 +15,8 @@ Additionally, the codebase has been extensively refactored. There is one breakin
     <PackageProjectUrl>https://github.com/tdwright/contabs</PackageProjectUrl>
     <PackageLicenseUrl>https://github.com/tdwright/contabs/blob/master/LICENSE</PackageLicenseUrl>
   </PropertyGroup>
-
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
     <DebugType>full</DebugType>
     <DebugSymbols>True</DebugSymbols>
   </PropertyGroup>
-
 </Project>

ConTabs/Exceptions/PublicPropertiesNotFoundException.cs

@@ -0,0 +1,10 @@
+using System;
+
+namespace ConTabs.Exceptions
+{
+    public class PublicPropertiesNotFoundException : Exception
+    {
+        public override string Message =>
+            "On Table<T> creation, no valid properties were identified. Check access modifiers.";
+    }
+}

ConTabs/Table.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Reflection;
+using ConTabs.Exceptions;
 
 namespace ConTabs
 {
@@ -54,6 +55,8 @@ private Table()
                 .Where(p => p.GetMethod.IsPublic)
                 .Select(p => new Column(p.PropertyType, p.Name))
                 .ToList();
+
+            if (!Columns.Any()) throw new PublicPropertiesNotFoundException();
         }
 
         public override string ToString()

ConTabsTestData/TestData.cs

@@ -31,6 +31,18 @@ public static List<MinimalDataType> ListOfMinimalData(int? limit = null)
             if (!limit.HasValue || limit < 0) limit = list.Count;
             return list.Take(limit.Value).ToList();
         }
+
+        public static List<InvalidTestDataType> ListOfInvalidTestData()
+        {
+            var list = new List<InvalidTestDataType>
+            {
+                new InvalidTestDataType(),
+                new InvalidTestDataType(),
+                new InvalidTestDataType(),
+                new InvalidTestDataType(),
+            };
+            return list;
+        }
     }
 
     public class TestDataType
@@ -47,4 +59,13 @@ public class MinimalDataType
         public int IntA { get; set; }
         public int IntB { get; set; }
     }
+
+    public class InvalidTestDataType
+    {
+        private string StringColumn { get; set; }
+        private int IntColumn { get; set; }
+        private decimal CurrencyColumn { get; set; }
+        private DateTime DateTimeColumn { get; set; }
+        private string HiddenProp { get; set; }
+    }
 }

README.md

@@ -56,6 +56,7 @@ This renders like this:
 
 If you're interested in contributing, we'd love to welcome you. Check out our [contributing guidelines](CONTRIBUTING.md) which should contain everything you need to make a successful contribution.
 
+
 ## Background
 
 ConTabs started life as an excuse for me (tdwright) to explore some bits and pieces. [I am writing up my experiences on my blog.](http://blog.tdwright.co.uk/series/modern-dotnet-dev-contabs/)