fix: sqlite test

README.md

@@ -248,16 +248,7 @@ Giving non-techy people the ability to create their software sounds exciting. Bu
 
 In essence, Teable isn't just another no-code solution, it's a comprehensive answer to the evolving demands of modern software development, ensuring that everyone, regardless of their technical proficiency, has a platform tailored to their needs.
 
-## 🌟 Star distribution
-
-<a href="https://next.ossinsight.io/widgets/official/analyze-repo-stars-map?repo_id=560299175&activity=stars" target="_blank" style="display: block" align="center">
-  <picture>
-    <source media="(prefers-color-scheme: dark)" srcset="https://next.ossinsight.io/widgets/official/analyze-repo-stars-map/thumbnail.png?repo_id=560299175&activity=stars&image_size=auto&color_scheme=dark" width="721" height="auto">
-    <img alt="Star Geographical Distribution of teableio/teable" src="https://next.ossinsight.io/widgets/official/analyze-repo-stars-map/thumbnail.png?repo_id=560299175&activity=stars&image_size=auto&color_scheme=light" width="721" height="auto">
-  </picture>
-</a>
-
-## :heart: Sponsors
+## Sponsors :heart:
 
 If you are enjoying some this project in your company, I'd really appreciate a [sponsorship](https://github.com/sponsors/teableio), a [coffee](https://ko-fi.com/teable) or a dropped star.
 That gives me some more time to improve it to the next level.

apps/nestjs-backend/src/db-provider/db.provider.interface.ts

@@ -1,4 +1,5 @@
 import type { DriverClient, IAggregationField, IFilter, ISortItem } from '@teable/core';
+import type { Prisma } from '@teable/db-main-prisma';
 import type { Knex } from 'knex';
 import type { IFieldInstance } from '../features/field/model/factory';
 import type { SchemaType } from '../features/field/util';
@@ -29,15 +30,19 @@ export interface IDbProvider {
 
   dropTable(tableName: string): string;
 
-  checkColumnExist(tableName: string, columnName: string): string;
-
   renameColumn(tableName: string, oldName: string, newName: string): string[];
 
   dropColumn(tableName: string, columnName: string): string[];
 
   // sql response format: { name: string }[], name for columnName.
   columnInfo(tableName: string): string;
 
+  checkColumnExist(
+    tableName: string,
+    columnName: string,
+    prisma: Prisma.TransactionClient
+  ): Promise<boolean>;
+
   dropColumnAndIndex(tableName: string, columnName: string, indexName: string): string[];
 
   modifyColumnSchema(tableName: string, columnName: string, schemaType: SchemaType): string[];

apps/nestjs-backend/src/db-provider/postgres.provider.ts

@@ -1,6 +1,7 @@
 import { Logger } from '@nestjs/common';
 import type { IAggregationField, IFilter, ISortItem } from '@teable/core';
 import { DriverClient } from '@teable/core';
+import type { PrismaClient } from '@teable/db-main-prisma';
 import type { Knex } from 'knex';
 import type { IFieldInstance } from '../features/field/model/factory';
 import type { SchemaType } from '../features/field/util';
@@ -45,14 +46,19 @@ export class PostgresProvider implements IDbProvider {
     return this.knex.raw('DROP TABLE ??', [tableName]).toQuery();
   }
 
-  checkColumnExist(tableName: string, columnName: string): string {
-    const [schemaName, dbTableName] = this.splitTableName(tableName);
-    return this.knex
-      .raw(
-        'SELECT EXISTS (SELECT FROM information_schema.columns WHERE table_schema = ? AND table_name = ? AND column_name = ?) AS exists',
-        [schemaName, dbTableName, columnName]
-      )
+  async checkColumnExist(
+    tableName: string,
+    columnName: string,
+    prisma: PrismaClient
+  ): Promise<boolean> {
+    const sql = this.knex
+      .raw('SELECT EXISTS (SELECT 1 FROM PRAGMA table_info(??) WHERE name = ?) AS exists', [
+        tableName,
+        columnName,
+      ])
       .toQuery();
+    const res = await prisma.$queryRawUnsafe<{ exists: boolean }[]>(sql);
+    return res[0].exists;
   }
 
   renameColumn(tableName: string, oldName: string, newName: string): string[] {

apps/nestjs-backend/src/db-provider/sqlite.provider.ts

@@ -2,6 +2,7 @@
 import { Logger } from '@nestjs/common';
 import type { IAggregationField, IFilter, ISortItem } from '@teable/core';
 import { DriverClient } from '@teable/core';
+import type { PrismaClient } from '@teable/db-main-prisma';
 import type { Knex } from 'knex';
 import type { IFieldInstance } from '../features/field/model/factory';
 import type { SchemaType } from '../features/field/util';
@@ -41,13 +42,14 @@ export class SqliteProvider implements IDbProvider {
     return this.knex.raw('DROP TABLE ??', [tableName]).toQuery();
   }
 
-  checkColumnExist(tableName: string, columnName: string): string {
-    return this.knex
-      .raw('SELECT EXISTS (SELECT 1 FROM pragma_table_info(??) WHERE name = ??) AS exists;', [
-        tableName,
-        columnName,
-      ])
-      .toQuery();
+  async checkColumnExist(
+    tableName: string,
+    columnName: string,
+    prisma: PrismaClient
+  ): Promise<boolean> {
+    const sql = this.columnInfo(tableName);
+    const columns = await prisma.$queryRawUnsafe<{ name: string }[]>(sql);
+    return columns.some((column) => column.name === columnName);
   }
 
   renameColumn(tableName: string, oldName: string, newName: string): string[] {

apps/nestjs-backend/src/features/record/open-api/record-open-api.service.ts

@@ -47,7 +47,6 @@ export class RecordOpenApiService {
   ) {
     const dbTableName = await this.recordService.getDbTableName(tableId);
 
-    console.log('orderRo', orderRo);
     const indexField = await this.viewService.getOrCreateViewIndexField(
       dbTableName,
       orderRo.viewId

apps/nestjs-backend/src/features/record/record.service.ts

@@ -334,10 +334,11 @@ export class RecordService implements IAdapterService {
 
   async getBasicOrderIndexField(dbTableName: string, viewId: string | undefined) {
     const columnName = `${ROW_ORDER_FIELD_PREFIX}_${viewId}`;
-    const exitSql = this.dbProvider.checkColumnExist(dbTableName, columnName);
-    const exists = await this.prismaService
-      .$queryRawUnsafe<{ exists: boolean }[]>(exitSql)
-      .then((res) => res[0].exists);
+    const exists = await this.dbProvider.checkColumnExist(
+      dbTableName,
+      columnName,
+      this.prismaService.txClient()
+    );
 
     if (exists) {
       return columnName;

apps/nestjs-backend/src/features/view/open-api/view-open-api.service.ts

@@ -440,7 +440,7 @@ export class ViewOpenApiService {
           newValue: new Date().toISOString(),
         });
 
-        await this.prismaService.$tx(async () => {
+        await this.prismaService.$tx(async (prisma) => {
           await this.viewService.updateViewByOps(tableId, viewId, [ops]);
           for (let i = 0; i < recordIds.length; i++) {
             const recordId = recordIds[i];
@@ -450,7 +450,7 @@ export class ViewOpenApiService {
               })
               .where('__id', recordId)
               .toQuery();
-            await this.prismaService.$executeRawUnsafe(updateRecordSql);
+            await prisma.$executeRawUnsafe(updateRecordSql);
           }
         });
       },

apps/nestjs-backend/src/features/view/view.service.ts

@@ -74,10 +74,11 @@ export class ViewService implements IReadonlyAdapterService {
 
   async existIndex(dbTableName: string, viewId: string) {
     const columnName = this.getRowIndexFieldName(viewId);
-    const exitSql = this.dbProvider.checkColumnExist(dbTableName, columnName);
-    const exists = await this.prismaService
-      .$queryRawUnsafe<{ exists: boolean }[]>(exitSql)
-      .then((res) => res[0].exists);
+    const exists = await this.dbProvider.checkColumnExist(
+      dbTableName,
+      columnName,
+      this.prismaService.txClient()
+    );
 
     if (exists) {
       return columnName;

apps/nestjs-backend/test/order-update.e2e-spec.ts

@@ -46,7 +46,7 @@ describe('order update', () => {
       await deleteTable(baseId, table.id);
     });
 
-    it('should update view order', async () => {
+    it('should update record order', async () => {
       const viewId = table.views[0].id;
       const record1 = { id: table.records[0].id };
       const record2 = { id: table.records[1].id };

packages/openapi/src/view/update-record-order.ts

@@ -4,9 +4,14 @@ import { registerRoute, urlBuilder } from '../utils';
 import { z } from '../zod';
 
 export const updateRecordOrdersRoSchema = z.object({
-  anchorId: z.string(),
+  anchorId: z.string().openapi({
+    description: 'Id of the record that you want to move other records around',
+  }),
   position: z.enum(['before', 'after']),
-  recordIds: z.string().array(),
+  recordIds: z.string().array().max(1000).openapi({
+    description: 'Ids of those records you want to move',
+    maxLength: 1000,
+  }),
 });
 
 export type IUpdateRecordOrdersRo = z.infer<typeof updateRecordOrdersRoSchema>;