fix: notify url splicing error (#504)

teableio · Mar 27, 2024 · 52a9329 · 52a9329
1 parent 1d5e37e
commit 52a9329
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/apps/nestjs-backend/src/features/notification/notification.service.ts b/apps/nestjs-backend/src/features/notification/notification.service.ts
@@ -7,7 +7,6 @@ import {
   NotificationStatesEnum,
   NotificationTypeEnum,
   notificationUrlSchema,
-  systemIconSchema,
   userIconSchema,
 } from '@teable/core';
 import type { Prisma } from '@teable/db-main-prisma';
@@ -202,7 +201,7 @@ export class NotificationService {
       case NotificationTypeEnum.CollaboratorMultiRowTag: {
         const { baseId, tableId, recordId } = urlMeta || {};
 
-        return `${origin}/base/${baseId}/${tableId}?recordId=${recordId}`;
+        return `${origin}/base/${baseId}/${tableId}${recordId ? `?recordId=${recordId}` : ''}`;
       }
     }
   }