Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create access token expiration date format #499

Merged
merged 1 commit into from Mar 26, 2024

Conversation

boris-w
Copy link
Contributor

@boris-w boris-w commented Mar 26, 2024

No description provided.

@boris-w boris-w requested a review from tea-artist March 26, 2024 06:41
@boris-w boris-w linked an issue Mar 26, 2024 that may be closed by this pull request
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8431881381

Details

  • 0 of 13 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 26.103%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nextjs-app/src/features/app/blocks/setting/access-token/form/ExpirationSelect.tsx 0 2 0.0%
packages/openapi/src/access-token/create.ts 0 11 0.0%
Totals Coverage Status
Change from base Build 8422545043: -0.003%
Covered Lines: 25600
Relevant Lines: 98072

💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8431881375

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 762 unchanged lines in 27 files lost coverage.
  • Overall coverage increased (+53.9%) to 79.964%

Files with Coverage Reduction New Missed Lines %
apps/nestjs-backend/src/global/knex/knex.extend.ts 2 45.24%
apps/nestjs-backend/src/features/collaborator/collaborator.service.ts 2 74.03%
apps/nestjs-backend/src/features/field/field-calculate/field-supplement.service.ts 2 95.18%
apps/nestjs-backend/src/share-db/utils.ts 3 77.14%
apps/nestjs-backend/src/utils/name-conversion.ts 4 76.47%
apps/nestjs-backend/src/features/access-token/access-token.service.ts 4 89.9%
apps/nestjs-backend/src/utils/file-utils.ts 6 83.78%
apps/nestjs-backend/src/features/field/model/field-dto/attachment-field.dto.ts 7 50.0%
apps/nestjs-backend/src/features/base/utils.ts 8 65.22%
apps/nestjs-backend/src/utils/update-order.ts 10 90.57%
Totals Coverage Status
Change from base Build 8422545043: 53.9%
Covered Lines: 25183
Relevant Lines: 31493

💛 - Coveralls

Copy link
Contributor

@caoxing9 caoxing9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boris-w boris-w merged commit e393228 into develop Mar 26, 2024
7 checks passed
@boris-w boris-w deleted the fix/access-token-create-expired-time branch March 26, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while trying to create an access token
4 participants