Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: standardize the copy html structure to avoid too many meaningles… #570

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

boris-w
Copy link
Contributor

@boris-w boris-w commented Apr 15, 2024

…s dom node attributes.

When copying content in Firefox browser, the text/html content set will be transformed by the browser itself, causing meaningless node attributes on the DOM to be removed. Therefore, this PR standardizes the node attributes on the DOM, no longer separating the fieldVo attribute to set it on DOM node attributes, instead placing the entire fieldVo on the data-field attribute.

Error case:
write html

<table><thead id="fldxxxx" name="xxxx" type="text" isPrimary="true" ...><tr></tr></thead>...<table>

read html

<table><thead id="fldxxxx" name="xxxx" type="text"><tr></tr></thead>...<table>

@boris-w boris-w requested a review from tea-artist April 15, 2024 07:31
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8685161669

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 20.339%

Totals Coverage Status
Change from base Build 8661365246: -0.04%
Covered Lines: 14586
Relevant Lines: 71713

💛 - Coveralls

@boris-w boris-w merged commit 9cfe841 into develop Apr 15, 2024
5 checks passed
@boris-w boris-w deleted the fix/copy-html branch April 15, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants