Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sharedb work flow #606

Merged
merged 7 commits into from
May 17, 2024
Merged

refactor: sharedb work flow #606

merged 7 commits into from
May 17, 2024

Conversation

boris-w
Copy link
Contributor

@boris-w boris-w commented May 16, 2024

List:

  • Updating cells using api and client-side optimistic updates.
  • ShareDB change to call api to get data instead of directly calling service.
  • Remove calculation code for shareDB.
  • Remove permission code for shareDB.

Test:

  • Successfully loaded view page.
  • View Page Success Collaboration.
  • View page modification of the grid successfully triggers a calculation and collaboration.
  • Successful cell modification by access token synergy.
  • Successfully loaded share view page.
  • Successful shared view page with password.
  • Shared view Page Success Collaboration.

@boris-w boris-w requested a review from tea-artist May 16, 2024 09:53
@coveralls
Copy link
Collaborator

coveralls commented May 16, 2024

Pull Request Test Coverage Report for Build 9122456990

Details

  • 359 of 520 (69.04%) changed or added relevant lines in 31 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+63.3%) to 82.766%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/table/table.service.ts 1 2 50.0%
apps/nestjs-backend/src/share-db/share-db.service.ts 2 3 66.67%
apps/nestjs-backend/src/ws/ws.gateway.dev.ts 0 1 0.0%
apps/nestjs-backend/src/share-db/auth.middleware.ts 14 16 87.5%
apps/nestjs-backend/src/share-db/utils.ts 0 2 0.0%
apps/nestjs-backend/src/share-db/share-db.adapter.ts 19 23 82.61%
apps/nestjs-backend/src/features/view/open-api/view-open-api.controller.ts 5 13 38.46%
apps/nestjs-backend/src/features/field/open-api/field-open-api.controller.ts 4 15 26.67%
apps/nestjs-backend/src/features/record/record.service.ts 7 19 36.84%
apps/nestjs-backend/src/features/share/share.controller.ts 42 55 76.36%
Totals Coverage Status
Change from base Build 9073367445: 63.3%
Covered Lines: 25847
Relevant Lines: 31229

💛 - Coveralls

@boris-w boris-w merged commit 7543a1f into develop May 17, 2024
8 checks passed
@boris-w boris-w deleted the refactor/share-db-flow branch May 17, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants