Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split base BaseFieldValue and BaseOperatorSelect to scale #665

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

caoxing9
Copy link
Contributor

No description provided.

@caoxing9 caoxing9 marked this pull request as draft June 14, 2024 14:53
@coveralls
Copy link
Collaborator

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9518124308

Details

  • 0 of 210 (0.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 18.681%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/sdk/src/components/filter/index.tsx 0 2 0.0%
packages/sdk/src/components/filter/condition/OperatorSelect.tsx 0 3 0.0%
packages/sdk/src/components/filter/condition/index.ts 0 3 0.0%
packages/sdk/src/components/filter/condition/FieldValue.tsx 0 10 0.0%
packages/sdk/src/components/filter/condition/BaseOperatorSelect.tsx 0 44 0.0%
packages/sdk/src/components/filter/condition/BaseFieldValue.tsx 0 148 0.0%
Totals Coverage Status
Change from base Build 9502682264: -0.01%
Covered Lines: 13866
Relevant Lines: 74224

💛 - Coveralls

/>
);

switch (field?.type) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about isMultipleCellvalue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

later to support, that's early omissions

@caoxing9 caoxing9 marked this pull request as ready for review June 17, 2024 11:25
@caoxing9 caoxing9 merged commit ed00ade into develop Jun 17, 2024
5 checks passed
@caoxing9 caoxing9 deleted the feat/filter-extend branch June 17, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants