Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed twoItemSwitcher text to black to make the options visible #34

Merged
merged 2 commits into from Feb 15, 2019

Conversation

@andrewkoung
Copy link
Contributor

commented Feb 15, 2019

fixes #33

@joelwass

This comment has been minimized.

Copy link
Collaborator

commented Feb 15, 2019

@andrewkoung Can we make this a prop instead of hardcoding? it looks like there will be different use cases for the switcher component having different letter colors

something like:

className={switcher__leftItem ${props.color} `

and then passing in color="black" or color="white" in the parent components wherever it's used

@stripedpajamas

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

@joelwass wouldn't that mean we'd necessarily need to write a color-class when passing a color into this component? I don't like the idea of having another piece of the project (scss file) be an indirect dependency of this component. How about we make a color prop directly alter the style and we can drop the class-colors.

@andrewkoung

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

I've created a color prop in my latest push. Is this fine?

@joelwass joelwass merged commit d553825 into teacherfund:master Feb 15, 2019

@andrewkoung andrewkoung deleted the andrewkoung:fix/donate-form branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.