Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding types order, moved types to package #52
adding types order, moved types to package #52
Changes from 2 commits
ff147c2
090eed9
8baca04
0b855a0
03fd408
fb69c30
0c5f938
6c851af
21369aa
d505025
fe93fe7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering if we should type the R as
R extends React.ComponentType
as the ComponentType would cover both React.FunctionComponent<> | React.ClassComponent<>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our advice is to use the
useStore
hook rather than thewithStore
HOC whenever it is a functional component. So I don't think it's wrong to have only theReact.ClassComponent
. In which cases would it make sense to use thewithStore
in a functional component?If there is some sense that we didn't take into account then I think it's okay to change it. 🤔