tl.tl API cleanups and tl refactors #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Teal Playground URL: https://414--teal-playground.netlify.app |
* move everything related to "tl build" to its own "submodule", preparing for deprecation (Cyan should be used as a build system instead) * move (almost) all "top-level" code to the end (except for the global state definitions, which will be changed in another commit)
squeeze a little bit more of performance from the code to compensate for the extra work in sorting map keys.
* make unknowns a kind of warning * only ever return Result values, do not take them as inputs * each Result only contains errors for the given file * use env.loaded (and env.loaded_order) to traverse all results and get all errors
This was originally added in 2019 to be at the beginning of the file, for the purpose explained in the comment below. Eventually it ended up moving around in the file, which made it ineffective. We've had reports of users confused that a git clone of tl was picking up the wrong tl.lua, so this little trick seems to have value -- let's bring it back.
hishamhm
force-pushed
the
tl-api-cleanups
branch
from
1dd22b0
to
3db8343
Compare
|
For what its worth (as I havent looked at the code much) I have a local branch of both cyan and teal-language-server up and running with this new api and they are both (seemingly) working. (And if anything isn't I'd blame that on my own test coverage rather than these changes) |
|
@euclidianAce Thank you for this feedback, it's super valuable. I'll go ahead and merge this. Another thing I will add is to move the version string from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl.tl API changes
Resultvalues, as their names imply, do not take them as inputsResultonly contains errors for the given fileenv.loaded(andenv.loaded_order) orresult.dependenciesto traverse all results and get all errors, as seen in thetlrefactor below.tl refactors
They're not as pretty as @euclidianAce's refactors in past recent PR, but this is more of a preparation for the deprecation of
tl buildand to use the API changes above.tl types: emit JSON map keys in alphabetical order — the order shouldn't matter, but it should make it easier to read when debugging