rockspec: Use HTTPS transport for fetching sources #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub are turning off the unencrypted Git protocol: https://github.blog/2021-09-01-improving-git-protocol-security-github/ When installing tl through luarocks, this would cause issues such as: ``` luarocks install tl Cloning into 'tl'... fatal: remote error: The unauthenticated git protocol on port 9418 is no longer supported. Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information. ``` To fix the issue, we set the source to an HTTPS URL, instead of a git:// URL.
|
Teal Playground URL: https://494--teal-playground.netlify.app |
|
@pdesaulniers Ooh, thanks for the heads up! This is likely to cause issues to a lot of existing rockspecs in the luarocks.org ecosystem; I think I should probably add a special case for this to auto-convert it and push a new LuaRocks release to make this Github switch smooth to all users. |
hishamhm
added a commit
to luarocks/luarocks
that referenced
this pull request
Nov 8, 2021
This avoids having to fix every rockspec that uses github.com. See https://github.blog/2021-09-01-improving-git-protocol-security-github/ For more context, see: teal-language/tl#494
|
I also released LuaRocks 3.8.0, which autoconverts |
ochaton
pushed a commit
to ochaton/luarocks
that referenced
this pull request
Jun 14, 2022
This avoids having to fix every rockspec that uses github.com. See https://github.blog/2021-09-01-improving-git-protocol-security-github/ For more context, see: teal-language/tl#494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub are dropping support for the unencrypted git:// protocol: https://github.blog/2021-09-01-improving-git-protocol-security-github/
When installing tl through luarocks, this would cause issues such as:
To fix the issue, this PR sets the source to an HTTPS URL, instead of a git:// URL.
Related: teal-language/teal-types#29