Prevent ordered_futures to swallow errors #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors that appear in the original source before reaching the ordered_futures is swallowed because of `$src_completed->done`, this will use `on_ready` to avoid that issue.
tm604
added a commit
that referenced
this pull request
Jan 16, 2021
New features:
- ->ordered_futures (->resolve) now also takes low/high parameters for backpressure
Bugs fixed:
- original source failure propagates after any pending Future instances are resolved,
thanks to Amin Marashi (Github issue #8)
|
Thanks for this. As discussed it's definitely not the right behaviour at the moment. I ended up approaching this from a slightly different direction:
This is in v2.006 - see from here for the details: v2.005...v2.006#diff-231b763a799aa30991bd3d1b87f26131fbfd0df3c5ec970d5f5dd1f0178b36aaR1221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors that appear in the original source before reaching the ordered_futures is swallowed because of
$src_completed->done, this will useon_readyto avoid that issue.