細かな修正: providerとrouteをまとめる, jsDocの追加 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
big-Miyabi
reviewed
Nov 25, 2021
frontend/src/utils/lazyImport.ts
Outdated
Comment on lines
3
to
19
| /** | ||
| * コンポーネントの遅延読み込み | ||
| * | ||
| * @param {() => Promise<I>} factory | ||
| * @param {K} name | ||
| */ | ||
| export const lazyImport = < | ||
| T extends React.ComponentType<FC>, | ||
| I extends { [K2 in K]: T }, | ||
| K extends keyof I, | ||
| >( | ||
| factory: () => Promise<I>, | ||
| name: K, | ||
| ): I => { | ||
| return Object.create({ | ||
| [name]: React.lazy(() => factory().then(module => ({ default: module[name] }))), | ||
| }) |
There was a problem hiding this comment.
この遅延読み込みって具体的にどんなことしてるかわかる？
どういう時に使ったらいいのかわからないから、折角JSDoc書いてるんだしその説明も欲しいな
こういう使い方とかぱっと見わからないやつはJSDocの@example構文使うといいよ！
↓みたいな書き方する
/**
* hogehgoe
* @return {*} {UseHoge}
* @example
```js
const hoge = useHoge() // テスト文章
```
*/あと普通に中のコード何してるのかいまいちわからなくて気になるから、参考リンクあるなら欲しいｗ
There was a problem hiding this comment.
React.lazyの遅延読み込みはdefault exportにしか対応してなくて、それが嫌だなってことでnamed exportに対応させてるだけ！
facebook/react#14603
JSDoc追加する！ありがとう
There was a problem hiding this comment.
あ〜〜〜〜なるほど！
Suspence内で使うのね！前教えてくれた本の最新版か、買うわ
ありがとう！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
実装の概要
Trello #84
Closes #84
目的
レビューして欲しいところ
不安に思っていること
拡張入れたけど意外とjsDoc推論してくれなくて雰囲気で書いてる
スケジュール
関連
今後のタスク