Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto start #9

Closed
talenguyen opened this issue Jul 18, 2017 · 7 comments
Closed

Auto start #9

talenguyen opened this issue Jul 18, 2017 · 7 comments

Comments

@talenguyen
Copy link

My opinion is it's better if we have option to auto start animation when it's ready than only java option.
@veghtomi
Copy link
Contributor

In the next release (at the weekend) I will add an autoStart attribute to it.

@k0shk0sh
Copy link
Contributor

@veghtomi I hope you don't mind, but i'm planning to take the issues that are currently opened including this, as i'm planning to use the library in https://github.com/k0shk0sh/FastHub and love to contribute to it :) . will be submitting a PR in awhile.

@veghtomi
Copy link
Contributor

Any contribution is appreciated @k0shk0sh ! Just ignore the #12 issue now.

@k0shk0sh
Copy link
Contributor

@veghtomi Already did before I see your response, would you consider or stash my changes?

@veghtomi
Copy link
Contributor

veghtomi commented Jul 21, 2017 •
edited
Loading

@k0shk0sh Feel free to submit! :)

@k0shk0sh
Copy link
Contributor

@veghtomi cool, I'll be committing the PR right away.

veghtomi added a commit that referenced this issue Jul 25, 2017
@veghtomi
Merge pull request #16 from k0shk0sh/master
e31b765 
fix for #9 & #12
@veghtomi
Copy link
Contributor

Feature is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@k0shk0sh @talenguyen @veghtomi