feat: implement ping pong communication to keep socket alive #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the pong reply to received ping messages in order to keep the websocket alive on the client side.
This resolves the user issue described here:
#20 (comment)
👴 👶 Behaviors
Before changes
Not responding to ping messages. I'm not sure what has changed recently but before this wasn't required to keep the socket open. Recently though, the socket is closing when inactive for a certain amount of time.
After changes
Reply to each ping message with a pong message, modelled after the JS SDK
✋ Manual testing