fix: correct registered state when disconnecting and implement disconnect option #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes and implements the disconnect feature.
Before this PR, disconnecting was not setting the registered state back to false meaning that logging in again would often not work unless the application was completely closed beforehand (gateway messages were ignored when registered = true).
Also, the sample application didn't have an example use case for the disconnect feature, so the UI has been updated too to allow for this functionality with an overflow menu (3 dots)
👴 👶 Behaviors
Before changes
Disconnect not working correctly
No disconnect implemented in sample UI
After changes
Register state set to false on disconnect
Ability to disconnect in sample app.
✋ Manual testing